![]() |
|

Identify and resolve SQL Server problems before they happen
|
|
By: Jeremy Kadlec | Read Comments (5) | Related Tips: More > Auditing and Compliance |
Problem
My company is just starting to look at adding functionality to retain historical data for key tables and columns for auditing purposes in many of our SQL Server databases. I have seen some of your recent tips related to triggers (Forcing Trigger Firing Order in SQL Server and Trigger Alternatives in SQL Server - OUTPUT Clause). Based on using triggers or a similar technology, what is the best way to store the historical data? What options are available to store the data? Are there really a variety of options? Should the historical data be in the same database as the original data? Does it really make a difference?
Solution
Being in the position to start to capture historical data is a good one. This gives you the opportunity to build a solution that can be used across various applications in the enterprise. As such, this is a big undertaking so an appropriate amount of time should be spent planning, building, testing and implementing the solution. If you agree with that premise, then this need should be considered a project and a formal process should be followed if the decisions you make have a wide scope across your applications and business processes.
Requirements
If you agree that capturing auditing data is a project, then it is appropriate to start with defining the requirements for the project. Consider gathering the following information as a baseline set of requirements:
Design Options
As indicated above, a couple of key technical design decisions relate to how the data is written to the auditing tables, where the auditing data is stored and if a consistent approach can be used to store the data for reporting purposes. With different answers to these questions leading to a different solution, let's outline a few different sample ideas to see if any of these could resolve your issue:
|
Base Table Copy |
| This approach could be considered the traditional auditing technique where an auditing table is created for each base table that needs to be audited. The design from the base table to the audit table are very similar, but the audit table has some additional columns to support managing the historical data (i.e. AuditID to serve as the identity, ModifiedBy to serve as a means to capture who made the change, etc.). Let's use a sample AdventureWorks table ([HumanResources].[EmployeePayHistory]) in the SQL Server 2005 database as an example: |
| USE [AdventureWorks] GO CREATE TABLE [HumanResources].[EmployeePayHistory_Audit]([AuditID] [int] IDENTITY (1,1) NOT NULL, [EmployeeID] [int] NOT NULL, [RateChangeDate] [datetime] NOT NULL, [Rate] [money] NOT NULL, [PayFrequency] [tinyint] NOT NULL, [ModifiedDate] [datetime] NOT NULL CONSTRAINT [DF_EmployeePayHistory_Audit_ModifiedDate] DEFAULT (getdate()), [ModifiedBy] [varchar](100) NOT NULL CONSTRAINT [DF_EmployeePayHistory_Audit_ModifiedBy] DEFAULT (SUSER_SNAME()) CONSTRAINT [PK_EmployeePayHistory_Audit_AuditID] PRIMARY KEY CLUSTERED ( [AuditID] ASC ) WITH (PAD_INDEX = OFF, IGNORE_DUP_KEY = OFF) ON [PRIMARY] ) ON [PRIMARY] GO |
|
Generic Design with Lookup Table |
| Another approach to auditing is with a generic table to store the data needed in conjunction with a lookup table to identify the original column for the audited data. The value in this design is the same table design can be used for each base table, the lookup table can be extended to support new columns and reporting is consistent. In addition, this design can be further extended to support a single database, an instance, an application or an entire environment with a few extra columns and the needed supporting infrastructure.
Below is one example for a single table to support auditing for a few columns in the SQL Server 2005 AdventureWorks database: |
| USE [AdventureWorks] GO CREATE TABLE [HumanResources].[EmployeePayHistory_Audit_Generic]([AuditID] [int] IDENTITY (1,1) NOT NULL, [AuditColumnID] [int] NOT NULL, [BaseTableUniqueKey_Value] [int] NOT NULL, [AuditColumnID_Value] [varchar](500), [ModifiedDate] [datetime] NOT NULL CONSTRAINT [DF_EmployeePayHistory_Audit_Generic_ModifiedDate] DEFAULT (getdate()), [ModifiedBy] [varchar](100) NOT NULL CONSTRAINT [DF_EmployeePayHistory_Audit_Generic_ModifiedBy] DEFAULT (SUSER_SNAME()) CONSTRAINT [PK_EmployeePayHistory_Audit_Generic_AuditID] PRIMARY KEY CLUSTERED ( [AuditID] ASC )WITH (PAD_INDEX = OFF, IGNORE_DUP_KEY = OFF) ON [PRIMARY] ) ON [PRIMARY] GO CREATE TABLE [HumanResources].[EmployeePayHistory_AuditLookup_Generic]([AuditColumnID] [int] IDENTITY (1,1) NOT NULL, [AuditColumnName] [varchar](150) NOT NULL, [ActiveFlag] [bit] NOT NULL CONSTRAINT [PK_EmployeePayHistory_AuditLookup_Generic_AuditID] PRIMARY KEY CLUSTERED ( [AuditColumnID] ASC )WITH (PAD_INDEX = OFF, IGNORE_DUP_KEY = OFF) ON [PRIMARY] ) ON [PRIMARY] GO ALTER TABLE [HumanResources].[EmployeePayHistory_Audit_Generic] ADD CONSTRAINT[FK_EmployeePayHistory_Audit_Generic_EmployeePayHistory_AuditLookup_Generic] FOREIGN KEY ( AuditColumnID ) REFERENCES [HumanResources].[EmployeePayHistory_AuditLookup_Generic] ( AuditColumnID ) GO INSERT INTO [HumanResources].[EmployeePayHistory_AuditLookup_Generic] ([AuditColumnName],[ActiveFlag])VALUES('RateChangeDate',1) GO INSERT INTO [HumanResources].[EmployeePayHistory_AuditLookup_Generic] ([AuditColumnName],[ActiveFlag])VALUES('Rate',1) GO SELECT *FROM [HumanResources].[EmployeePayHistory_AuditLookup_Generic] GO |
Let's explain each of the columns to help illustrate the point:
|
|
XML Design - Per Database Design |
| USE [AdventureWorks] GO CREATE TABLE [dbo].[Database_Audit_XML]([AuditID] [int] IDENTITY (1,1) NOT NULL, [TableName] [varchar](100) NOT NULL, [ColumnName] [varchar](100) NOT NULL, [AuditData] [xml] NOT NULL, [ModifiedDate] [datetime] NOT NULL CONSTRAINT [DF_Database_Audit_XML_ModifiedDate] DEFAULT (getdate()), [ModifiedBy] [varchar](100) NOT NULL CONSTRAINT [DF_Database_Audit_XML_ModifiedBy] DEFAULT (SUSER_SNAME()) CONSTRAINT [PK_Database_Audit_XML_AuditID] PRIMARY KEY CLUSTERED ( [AuditID] ASC ) WITH (PAD_INDEX = OFF, IGNORE_DUP_KEY = OFF) ON [PRIMARY] ) ON [PRIMARY] GO |
Let's explain each of the columns to help illustrate the point:
|
Depending on where the data is stored (i.e. instance, centrally, etc.) it is necessary to store additional data for reporting purposes. These columns may include:
In addition to adding columns to the tables as the suggestions above outline, it is also necessary to setup the infrastructure from a data perspective to replicate the data or be able to write the data directly to the tables. This could mean taking one of more of the following approaches:
Next Steps
| Wednesday, April 02, 2008 - 11:56:06 AM - MarkJo_FP | Read The Tip |
|
I also have to do data change auditing on our database. Our current implementation has been in place for several years but I am looking at changing it. The new approach is based on an article by Itzik Ben-Gan a couple years ago. Below is a summary of the current approach and the proposed approach. Any comments would be greatly appreciated.
Current Approach Currently auditing is done with 3 "INSTEAD OF" triggers (trg<tableName>Insert, trg<tableName>Update, trg<tableName>Delete) on each table and 2 auditing tables (AuditLog and AuditDetail). The insert trigger copies the data from Inserted to a temp table, calls a procedure that populates the AuditLog table with the table name, Table PK, Operation, who made the change, the time of the change and what computer the changes was made on. The procedure then inserts a row for each column of the table into the AuditDetail table. This contains the column name, old value (always NULL in this case) and new value. Once the procedure is completed the temp table is dropped and the data from INSERTED is inserted into the base table. The Update trigger copies data from Inserted and Deleted into temp tables and calls a procedure that populates the AuditLog table just like the insert trigger and then compares the inserted and deleted temp tables column by column and inserts a row in the AuditDetails table for each of the columns that have changed. The temp tables are then dropped and the base table is updated. The Delete trigger copies data from Deleted into a temp table and calls a procedure that populates the AuditLog table and inserts a row for each column of the table into the AuditDetail table and then deletes the record in the base table. Pros: Only 2 additional tables required. Cons: Performances is terrible in a table with millions of records. Bulk changes to a table take hours. New Approach What I am considering for the new approach is this. One trigger on each table and 3 additional tables per audited table. The trigger identifies the type of statement that fired the trigger and the number of rows affected. Uses table variable instead of temp tables which allow roll back of a change with ability to log the attempted change. Has logic to log attempted changes to the data and block the change (e.g. changing the PK column or integrity violations). Each audited table will have a <TableName>AuditHeader table that contains the dmltype, date of change, who made the change, application name, what computer the change was made from, a failed flag and comment if the attempted change failed or was blocked. Each audited table will also have a <TableName>InsAuditDelDetail table that contain a FK to the header table and a column for each of the columns in the base table. This table will store the full row of data for inserts and deletes. The final table is <TableName>AuditUpdDetail. This table contain a FK to the Header table, the name of the column, the old value and new value for each of the columns that changed in the update. Pros: Performance is very good. I ran a change of several hundred thousand records and the time went from about 4 minutes to 6 minutes. A comercial package using two audit tables ran for 20 minutes and crashed. Current version ran for several hours and I killed it. Avoids hot spots created by all user changes resulting in hitting just 2 tables (the detail in particular). Cons: A lot of extra tables. May be more difficult to generate a view of all changes depending on requirements Admittedly bulk changes do not happen often but when they do it is a killer and we are seeing performance problems under normal use with the current approach when the log grows too large. Some of this can be mitigated by table and index changes. The <TableName>AuditUpdDetail could be eliminate and the <TableName>InsAuditDelDetail used. The before and after values would need to be determined by comparison of the 2 records. I have seen this approach also. Another downside to this is that you are storing an entire record even if only one column changed (a big hit for tables with image data, file attachments, etc.)
|
|
| Friday, April 04, 2008 - 7:21:33 AM - admin | Read The Tip |
|
MarkJo_FP, Thank you for sharing some of the challenges you are facing today with auditing. Although your new solution does have many tables it sounds like the performance is acceptable and is something you are willing to manage. How do you think a generic solution either with an XML column or a generic table would fair in that scenario? We have implemented both solutions under different circumstances and they have appeared to perform well and meet the overall reporting needs. Just interested in your thoughts on the matter as opposed to recommending a different approach. Thank you,
|
|
| Tuesday, April 08, 2008 - 9:30:14 AM - MarkJo_FP | Read The Tip |
|
If I am understanding your generic solution, I think it is very similar to out current approach of using 2 tables. Your implementation has the flexibility to audit selected columns in a table whereas we audit the entire table. I assume you use triggers to populate these tables when a change is made. You are storing the table and column information in one table whereas we have a header table where we store the table name, rowid, operation, modifiedby, modifieddate and computername and then a child table which stores the column name, old value and new value. Since you are storing only one value for the column you are apparently storing either the new value for the column or the old value for the column. How do you distinguish between inserts, updates and deletes when reporting? How does it handle failed update attempts? We have an auditlog viewer as part of the product that allows searching the log based on a variety of criteria. Without storing the old and new values I assume you would need to join on the previous change for that column. Storing the Old and New values is where we ended up with the temp tables and INSERTED and DELETED tables as I described in my post. Have you tried doing a bulk load (or change) of data with your auditing in place. It is not very common but I do run into it once in a while. If I am missing something in my assumptions above let me know. I am always looking for better ways to deal with the auditing issues. Thanks. Mark
|
|
| Friday, April 11, 2008 - 10:08:41 AM - admin | Read The Tip |
|
Mark, Thank you for the lengthy reply and feedback. Generic tables:
XML tables
Thank you, |
|
| Thursday, May 27, 2010 - 4:08:52 PM - DylanGross | Read The Tip |
| Hello I am Dylan Goss and I love this forum. I hope to learn from you, thanks! | |
|
privacy | disclaimer | copyright | advertise | about authors | contribute | feedback | giveaways | user groups Some names and products listed are the registered trademarks of their respective owners. Edgewood Solutions LLC | MSSharePointTips.com | MSSQLTips.com |